Add --fix CLI option
#367
Merged
Add --fix CLI option
#367
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Turbo87
reviewed
Apr 29, 2021
Mikek2252
force-pushed
the
fix-option
branch
2 times, most recently
from
9d26824 to
ba2121a
Compare
Turbo87
reviewed
May 27, 2021
index.js
Outdated
| @@ -55,6 +57,7 @@ async function run(rootDir, options = {}) { | |||
| log(' 👏 No unused translations were found!'); | |||
| } else { | |||
| log(` ⚠️ Found ${chalk.bold.yellow(unusedTranslations.size)} unused translations!`); | |||
| log(' use --fix to remove all unused translations'); | |||
There was a problem hiding this comment.
Suggested change
| log(' use --fix to remove all unused translations'); | |
| log(' You can use --fix to remove all unused translations.'); |
so that this aligns a little better :)
There was a problem hiding this comment.
and I guess we should only log this line if shouldFix is not true?
index.js
Outdated
| @@ -13,6 +13,8 @@ const YAML = require('yaml'); | |||
|
|
|||
| async function run(rootDir, options = {}) { | |||
| let log = options.log || console.log; | |||
| let writeToFile = options.writeToFile || fs.writeFileSync; | |||
| let shouldFix = process.argv.includes('--fix'); | |||
There was a problem hiding this comment.
I would prefer to pass fix: true/false in as one of the options. That way we don't rely on the global process.argv state and this run() function stays reusable. It also means you don't have to use the process.argv.push('--fix') hack below 😉
There was a problem hiding this comment.
like this?
Suggested change
| let shouldFix = process.argv.includes('--fix'); | |
| let shouldFix = options.fix || process.argv.includes('--fix'); |
There was a problem hiding this comment.
I was thinking more like this:
Suggested change
| let shouldFix = process.argv.includes('--fix'); | |
| let shouldFix = options.fix ?? false; |
and then in bin/cli.js we use run(rootDir, { fix: process.argv.includes('--fix') })
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR add a --fix option when running ember-intl-analyzer that should remove all unused translations whether they are whole keys or nested.
This is the first draft
Todo: