Add support for basic conditionals in the t helper #320
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Turbo87
reviewed
Feb 1, 2021
index.js
Outdated
| translationKeys.add(firstParam.value); | ||
| } else if (firstParam.type === 'SubExpression' && firstParam.path.original === 'if') { | ||
| let conditionResults = firstParam.params.slice(1); | ||
| conditionResults.forEach(conditionResult => { |
There was a problem hiding this comment.
why did you use forEach() here? I'm wondering if it would be easier to understand if we looked at firstParam.params[1] and firstParam.params[2] directly
There was a problem hiding this comment.
Yeah fine with that, just didnt want to repeat myself, but will change if you think it reads better
Mikek2252
force-pushed
the
find-translations-in-conditions
branch
from
264db42 to
c302c18
Compare
Turbo87
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding additional parsing to check if the t helper has a conditional and adding the potential options.
Addresses #143