Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

git lfs installed check doesn't work with nix #19

Open
rupurt opened this issue Dec 15, 2023 · 1 comment
Open

git lfs installed check doesn't work with nix #19

rupurt opened this issue Dec 15, 2023 · 1 comment

Comments

@rupurt
Copy link

rupurt commented Dec 15, 2023

Howdy 👋

The current installed check for git lfs doesn't work with NixOS or Nix flakes unfortunately ☹️ The nix packages don't add the config in

llm-mlc/llm_mlc.py

Line 42 in b05eec9

["git", "config", "--get", "filter.lfs.clean"], encoding="utf-8"
. How do you feel about using a subprocess.run check with git lfs status?
@rupurt
Copy link
Author

rupurt commented Dec 15, 2023

Added a PR in #20

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@rupurt