-
Notifications
You must be signed in to change notification settings - Fork 79
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upstream dependency has a vulnerability (minimist 0.0.8 from mkdirp 0.5.1) #123
Comments
sure @DarthHater PR is welcomed, sorry for the late reply, been crazy busy lately |
@akhoury PR sent! |
thanks! |
Appreciate it, you and this project @akhoury ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Hi there!
I work on a tool called
auditjs
, and in one of our scans of our tool, we discovered that:CVE for minimist is here:
https://nvd.nist.gov/vuln/detail/CVE-2020-7598
You'll want to examine the actual risk to your application, but my suggestion would be to just remove the
mkdirp
dependency:The suggestion from me (and I'd gladly send you the PR to do so) is to remove the
mkdirp
and usefs.mkDirSync
in node 10.12 forward. Node 8 is sunset at this point.You can do:
fs.mkdirSync(targetDir, { recursive: true });
to accomplish whatmkdir -p
does.Let me know if you'd like a PR, glad to help out!
We use
node-persist
by the way and I love it. Thanks a ton for creating this!The text was updated successfully, but these errors were encountered: