Merge pull request #2 from simonihmig/fix

Fix updateNode being called with undefined rootNode
simonihmig · Sep 29, 2020 · 8c35231 · 8c35231
2 parents ed9ec85 + 941011f
commit 8c35231
Show file tree

Hide file tree

Showing 2 changed files with 16 additions and 5 deletions.
diff --git a/src/-private/create-store.ts b/src/-private/create-store.ts
@@ -31,20 +31,23 @@ export default function createStore<S, A extends Action, Ext, StateExt>(
   );
 
   const originalGetState = store.getState.bind(store);
-
-  let rootNode;
-
-  store.getState = (): S => {
+  const ensureRootNode = (): void => {
     if (rootNode === undefined) {
       rootNode = createNode({
         state: originalGetState(),
       });
     }
+  }
 
+  let rootNode;
+
+  store.getState = (): S => {
+    ensureRootNode();
     return rootNode.proxy.state;
   };
 
   store.subscribe(() => {
+    ensureRootNode();
     updateNode(rootNode, {
       state: originalGetState(),
     });

diff --git a/tests/unit/basic-test.js b/tests/unit/basic-test.js
@@ -25,7 +25,15 @@ function createCache(fn) {
 
 module('Unit | basic', () => {
   module('primitive root', () => {
-    test('it works', (assert) => {
+    test('redux works', (assert) => {
+      let store = createStore((state = 0) => ++state);
+
+      store.dispatch({ type: 'INCREMENT' });
+
+      assert.equal(store.getState(), 2, 'value is correct');
+    });
+
+    test('caching works', (assert) => {
       let store = createStore((state = 0) => ++state);
 
       let cache = createCache(() => store.getState());