Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update the prebuilt target from 8.12.0 to 14.17.0 #25

Closed
bn3t opened this issue Oct 21, 2021 · 5 comments
Closed

Update the prebuilt target from 8.12.0 to 14.17.0 #25

bn3t opened this issue Oct 21, 2021 · 5 comments

Comments

@bn3t
Copy link

bn3t commented Oct 21, 2021

When using this module inside an electron project with electron-forge (6.0.0-beta.61) using node 14.x, I was having issues with prebuilds.

 Uncaught Exception:
Error: No native build was found for platform= win32 arch=x64 runtime= electron abi= 89 uv=1 libc=glib node= 14.17.0 electron=14.0.1 webpack=true

The solution for me was to make native-reg build with the target 14.17.0:

 "build:x64": "prebuildify --napi --target [email protected] --cwd binding --arch x64",

Would you agree to do this change? I can prepare a PR for this change.

@bn3t bn3t changed the title Update the target from 8.12.0 to 14.17.0 Update the prebuilt target from 8.12.0 to 14.17.0 Oct 21, 2021
@simonbuchan
Copy link
Owner

It's a bit confusing? I'm targeting N-API where the whole point is it's stable. I'd rather track down why electron-forge is rejecting it, otherwise this issue will probably just keep coming up (eg v16 just went LTS)

@simonbuchan
Copy link
Owner

Could you check if v0.3.6 in @next fixes this? I'm noticing I never released the fix for #23, which was pretty similar looking.

@bn3t
Copy link
Author

bn3t commented Oct 22, 2021

Ah indeed, maybe my local build worked because I based it on master and not on the tag. I didn't realize it was not released.

Anyways, thanks for your support. It works.

Great project by the way, Well written and works like a charm.

@simonbuchan
Copy link
Owner

Really should have been released by now, so I went ahead and did so, if you would prefer not to have a @next tag.

Honestly, I'm not likely to do much to this without a major re-write at this point and it seems pretty well used, so really, I might as well bump this to 1.0.0 so people aren't scared off!

@simonbuchan
Copy link
Owner

Just to let you know, if you pull now, you will get the v1.0.0 publish. Only effective change is bumping the node-addon-api package, which technically makes the minimum node version v12.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants