-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update the prebuilt target from 8.12.0 to 14.17.0 #25
Comments
It's a bit confusing? I'm targeting N-API where the whole point is it's stable. I'd rather track down why electron-forge is rejecting it, otherwise this issue will probably just keep coming up (eg v16 just went LTS) |
Could you check if v0.3.6 in |
Ah indeed, maybe my local build worked because I based it on master and not on the tag. I didn't realize it was not released. Anyways, thanks for your support. It works. Great project by the way, Well written and works like a charm. |
Really should have been released by now, so I went ahead and did so, if you would prefer not to have a Honestly, I'm not likely to do much to this without a major re-write at this point and it seems pretty well used, so really, I might as well bump this to 1.0.0 so people aren't scared off! |
Just to let you know, if you pull now, you will get the v1.0.0 publish. Only effective change is bumping the |
When using this module inside an electron project with electron-forge (6.0.0-beta.61) using node 14.x, I was having issues with prebuilds.
The solution for me was to make native-reg build with the target 14.17.0:
Would you agree to do this change? I can prepare a PR for this change.
The text was updated successfully, but these errors were encountered: