Stopped working in 3.5.91

[towolf]

(gnome-shell:2740): Clutter-WARNING **: Attempting to add actor of type 'ShellGenericContainer' to a container of type 'StBoxLayout', but the actor has already a parent of type 'StBin'.
      JS LOG: Extension "[email protected]" had error: TypeError: meta is null

[bmbaker]

have a similar problem
JS LOG: Extension "[email protected]" had error: TypeError: St.IconType is undefined
this is from the .cache/gdm/session.log

cheers :-)

[bmbaker]

hi simon :-) any chance of getting a bump to GS 3.6 version ?
cheers BB

[canek-pelaez]

I got an update for GNOME 3.6. I send it to simon04, but I suppose he has been too busy to apply it, so I forked the repo. If you only want for the extension to work in GNOME 3.6, you can cherry pick the following commit:

https://github.com/canek-pelaez/gnome-shell-extension-weather/commit/2b58327bf183c94c788a13d746373efc22a3f3c1

However, I added some improvements, and I plan to keep improving the code (including a better configuration window, and a update to the build system). You can follow the changes in my fork:

https://github.com/canek-pelaez/gnome-shell-extension-weather.git

[towolf]

Nice, thanks.

Will you port the prefs to the official gnome-shell-extension-prefs system?

[canek-pelaez]

I can try ;)

[towolf]

You can throw out the Python code then. It makes sense.

Also, if you look at the network above, there’s quite a few branches with various other touch-ups. Perhaps see if there’s anything to merge there.

[canek-pelaez]

It seems only mockturtl fork has recent activity, but outside of translations seems to be specific to Cinnamon. I haven't touched the translations, and I don't think I will; however, I accept patches ;)

[canek-pelaez]

OK, I added support for the gnome-shell-extension-prefs tool, you can check it in my fork of the repo. I also cleaned up the build system (it now passes make distcheck), and fixed some minor things.

I'm not a designer, so the GUI for configuring the weather extension probably sucks big time. For the GUI I used a glade file:

https://github.com/canek-pelaez/gnome-shell-extension-weather/blob/master/src/prefs.xml

Anyone better at design, please take a look at it and send me any constructive criticism, or even better, patches.

[towolf]

It’s already quite fine; i.e., it works.

The main thing is to not install system-wide but to $HOME/.local/share/gnome-shell/extensions by default. Many other extenstions do that nowadays. Also the GSettings schema has to be local to the directory.

You may want to compare what other extensions do like this simple one

About the dialog, normally you want 12px padding all around, and the widgets themselves should be left aligned in a column. The label for the widgets are left aligned too.

cf:

I could do it, but the whole story with setting up a clone, installing glade, and making a pull request would taker longer than you simply introducing a simple gtk grid.

You may want to put a link next to the ID field where people can look up their WOID.

[bmbaker]

Super duper stuff :-)

[canek-pelaez]

Thanks for the input. I updated the extension; now a user can do:

./autogen --prefix=$HOME/.local --with-local-install=yes
make
make install

and the extension will be installed locally (like the extensions in https://extensions.gnome.org). This also will allow us to easily generate a zip file, which I believe is required for inclusion in https://extensions.gnome.org.

I will work in the HID suggestions for the prefs widget and in a mechanism for automatically getting WOEID's next week.

[canek-pelaez]

OK, so I couldn't leave this alone, so I implemented the changes to the UI (I'm still not sure of it), and the WOEID search integrated in the preferences dialog. You can see a screenshot here:

Testing is appreciated.

[canek-pelaez]

By the way, does anyone know who I need to write to so the extension is considered for https://extensions.gnome.org inclusion?

[towolf]

Yes, perfect.

On the extensions page there’s an »Add yours« link on top where oyu can submit it.

[canek-pelaez]

I just submitted it. Also, I'm going to move all the disussion related to the extension to my fork, so if someone has anyting to say related to the extension, please do it in the issues section of my fork:

https://github.com/canek-pelaez/gnome-shell-extension-weather/issues