Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use zlib-ng #245

Open
t20100 opened this issue Dec 14, 2022 · 2 comments
Open

Use zlib-ng #245

t20100 opened this issue Dec 14, 2022 · 2 comments

Comments

@t20100
Copy link
Member

t20100 commented Dec 14, 2022

Following addition of blosc2 (PR #201), blosc2 and others are using zlib.

Yet, Blosc2 can use zlib-ng (sources included in internal-complibs/), and it should also be possible to use zlib-ng as a replacement for zlib for other filters too.

This is need to look at how zlib-ng handles building with SIMD instructions.
@t20100 t20100 mentioned this issue Dec 14, 2022
Merged
@bnavigator
Copy link

This already seems to be the case?

hdf5plugin/setup.py

Line 783 in 2782806

zlib_dir = glob('src/c-blosc/internal-complibs/zlib*')[0]

hdf5plugin/src/c-blosc2/internal-complibs/zlib-ng-2.0.7/README.md

Line 1 in 2782806

## zlib-ng

@t20100
Copy link
Member Author

t20100 commented Mar 4, 2024

It'a currently using zlib (embedded in cblosc v1), not zlib-ng (embedded in cblosc v2).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@bnavigator @t20100