Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update config to be compatible with Webpack 4 #34

Closed
scott1702 opened this issue Apr 26, 2019 · 4 comments
Closed

Update config to be compatible with Webpack 4 #34

scott1702 opened this issue Apr 26, 2019 · 4 comments

Comments

@scott1702
Copy link

The JS seems to build fine but the CSS fails as extract-text-webpack-plugin is deprecated for Webpack 4.

See https://github.com/webpack-contrib/extract-text-webpack-plugin#usage

⚠️ Since webpack v4 the extract-text-webpack-plugin should not be used for css. Use mini-css-extract-plugin instead.

@maxime-rainville
Copy link
Contributor

We're still on webpack 2 and I don't think we have any urgency to upgrade to webpack 4 any time soon.

Is this holding you back in some way?

@scott1702
Copy link
Author

It's not blocking, it just means I'm restricted to using webpack 2 in modules where I want to take advantage of silverstripe/webpack-config.

@maxime-rainville
Copy link
Contributor

I'm not sure it would be possible to develop a CMS module that uses a webpack version different from the silverstripe/admin one.

We're not committed to any specific timeframe in terms of webpack upgrade, but last time we had a discussion about it, our thinking was that it might be a SilverStripe 5 thing.

@GuySartorelli
Copy link
Member

We're doing this as part of CMS 5. Closing in favour of silverstripe/silverstripe-admin#1312

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants