Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

No author is recorded for a snapshot #41

Closed
NightJar opened this issue Apr 14, 2021 · 4 comments
Closed

No author is recorded for a snapshot #41

NightJar opened this issue Apr 14, 2021 · 4 comments

Comments

@NightJar
Copy link

NightJar commented Apr 14, 2021

In various situations the AuthorID field of a Snapshot is left at default (0) inaccurately recording who has made a snapshot (e.g. published a page and all child elements).

This issue is opened on the snapshots module rather than the snapshots-admin module as it relates to database information, rather than an Author Name displaying in the CMS.

However, related, it was found and caused confusion in part with trying to lightly debug why silverstripe/silverstripe-versioned-snapshot-admin#50 is happening. I thought the lack of AuthorID might be the reason the Author's name was missing in the UI. It does not appear to be this way however.

Reproduce

  • Create project, require snapshot(-admin), dev/build, etc.
  • /admin/pages/edit/show/2
  • Type "Changes" into the Content TinyMCE
  • Click Save & Publish
  • Click History tab 👀 One entry, by you, just now. All seems correct.
  • View database VersionedSnapshot table. 👀 AuthorID is 0

image

I note that the absence of the AuthorID does not seem to impact the function of the history log in this case

image

Perhaps I'm misunderstanding the purpose of this field. In more advanced tests I have noted it is correctly inputted to the database sometimes. This is not because I am Default Admin as this is still a valid user with an ID.

@unclecheese
Copy link

Have not been able to replicate this. Will need more details on reproducing.

@NightJar
Copy link
Author

NightJar commented Apr 19, 2021

Sorry, I got distracted in struggling to reproduce another issue in the history domain.

I've updated the OP.

@unclecheese
Copy link

Good catch. This should be resolved by f60c269

@NightJar
Copy link
Author

NightJar commented May 3, 2021

This has been resolved - although I'm testing with unclecheese:pulls/master/will-workflow-food it also contains f60c269

@NightJar NightJar closed this as completed May 3, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants