From 684a9eb8aea2aba71c2b40d945900597817ac42b Mon Sep 17 00:00:00 2001 From: Sabina Talipova Date: Thu, 19 Oct 2023 16:51:41 +1300 Subject: [PATCH] MNT Remove TODO comments --- client/src/components/HistoryViewer/HistoryViewer.js | 2 -- client/src/components/HistoryViewer/HistoryViewer.scss | 3 +-- .../components/HistoryViewer/HistoryViewerVersionDetail.js | 4 +--- 3 files changed, 2 insertions(+), 7 deletions(-) diff --git a/client/src/components/HistoryViewer/HistoryViewer.js b/client/src/components/HistoryViewer/HistoryViewer.js index 905521e0..6ed53788 100644 --- a/client/src/components/HistoryViewer/HistoryViewer.js +++ b/client/src/components/HistoryViewer/HistoryViewer.js @@ -409,8 +409,6 @@ HistoryViewer.propTypes = { }), page: PropTypes.number, schemaUrl: PropTypes.string, - // @todo replace this with import { VIEW_MODE_STATES } from 'state/viewMode/ViewModeStates' - // when webpack-config has this export available via silverstripe/admin previewState: PropTypes.oneOf(['edit', 'preview', 'split']), actions: PropTypes.object, onSelect: PropTypes.func, diff --git a/client/src/components/HistoryViewer/HistoryViewer.scss b/client/src/components/HistoryViewer/HistoryViewer.scss index e5445662..16a5a44c 100644 --- a/client/src/components/HistoryViewer/HistoryViewer.scss +++ b/client/src/components/HistoryViewer/HistoryViewer.scss @@ -59,7 +59,6 @@ $diff-added-color: #b9f1c8; } } -// Todo: remove this when the CMS is React driven and we don't need this hack .history-viewer__preview { margin-top: -54px; } @@ -84,7 +83,7 @@ $diff-added-color: #b9f1c8; } } -// Hide preview on small devices. @todo replace this with a view toggle component +// Hide preview on small devices. @include media-breakpoint-down(md) { .history-viewer__preview { display: none; diff --git a/client/src/components/HistoryViewer/HistoryViewerVersionDetail.js b/client/src/components/HistoryViewer/HistoryViewerVersionDetail.js index 9aaee895..f0e0cc5b 100644 --- a/client/src/components/HistoryViewer/HistoryViewerVersionDetail.js +++ b/client/src/components/HistoryViewer/HistoryViewerVersionDetail.js @@ -63,7 +63,7 @@ class HistoryViewerVersionDetail extends PureComponent { /** * Until the CMS is fully React driven, we must control certain aspects of the CMS DOM with - * manual CSS tweaks. @todo remove this when React drives the CMS. + * manual CSS tweaks. * * @param {boolean} add */ @@ -226,8 +226,6 @@ HistoryViewerVersionDetail.propTypes = { }), PropTypes.bool, ]), - // @todo replace this with import { VIEW_MODE_STATES } from 'state/viewMode/ViewModeStates' - // when webpack-config has this export available via silverstripe/admin previewState: PropTypes.oneOf(['edit', 'preview', 'split']), };