Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TODO: Investigate ability to turn on / off Versioned::prepopulate_versionnumber_cache in RecoverUploadLocationsHelper::chunk method #1244

Closed
sabina-talipova opened this issue Oct 10, 2023 · 1 comment

Comments

@sabina-talipova
Copy link
Contributor

sabina-talipova commented Oct 10, 2023

Description

TODO comment unclear suggested to use Versioned::prepopulate_versionnumber_cache property in RecoverUploadLocationsHelper::chunk method. Investigate ability to turn on / off Versioned::prepopulate_versionnumber_cache in RecoverUploadLocationsHelper::chunk method.
See

private function chunk($chunkSize = 100)
{
$greaterThanID = 0;
do {
$count = 0;
$chunk = $this->getQuery()
->setLimit($chunkSize)
->addWhere([
'"SubmittedFileFieldTable"."UploadedFileID" > ?' => $greaterThanID
])->execute();
// TODO: Versioned::prepopulate_versionnumber_cache
foreach ($chunk as $item) {
yield $item;
$greaterThanID = $item['UploadedFileID'];
++$count;
}
} while ($count > 0);
}

@GuySartorelli
Copy link
Member

I'm going to veto this one - that buildtask isn't used very often and I don't think that method would provide sufficient performance benefits for us to spend time looking into this.

@GuySartorelli GuySartorelli closed this as not planned Won't fix, can't repro, duplicate, stale Oct 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants