Textarea without max length

[rasstislav]

Hello,

I have a question.

What if the field is a Textarea? We no longer need to set the maximum number of characters?

silverstripe-userforms/code/Model/EditableFormField/EditableTextField.php

Lines 188 to 190 in 3576db9

	if ($field instanceof TextField) {
	$field->setMaxLength((int) $this->MaxLength);
	}

Thank for response :-)

Related Issues

• missing maxLength validation in TextareaField silverstripe-framework#10928

[michalkleiner]

Hi @rasstislav.
As we don't provide user support or answer generic questions through the issue tracker, can you please clarify if you are reporting a bug or raising an enhancement request or something else?

[rasstislav]

Hi @michalkleiner.
I think it's a mistake, or rather a deficiency, but it can also be labeled as an enhancement. For this purpose, I had to make extension, but I think that it is missing in this module. That's why I marked it as more of a question.

[maxime-rainville]

Just had a look. If you set a maxlength on a text field and tell it to be two rows, you get a <textarea> without a maxlength attribute. You do get a data-rule-maxlength which the front end JS seems to pick up and apply validation for. However, the back end seems to ignore it.

I'd say this is probably a bug, but a low impact one.

[rasstislav]

Hi @maxime-rainville.
Yes, back end validation is missing. Thanks :-)

[GuySartorelli]

PR merged. This will be automatically tagged by GitHub Actions