Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SS4: Missing chosen-sprite.png in TagField.css #102

Closed
axllent opened this issue Oct 26, 2017 · 6 comments
Closed

SS4: Missing chosen-sprite.png in TagField.css #102

axllent opened this issue Oct 26, 2017 · 6 comments

Comments

@axllent
Copy link

axllent commented Oct 26, 2017

TagField.css refers to url('../../framework/admin/thirdparty/chosen/chosen/chosen-sprite.png') which, although still exists in the admin, is no longer available via /resources/ nor via framework.

@zanderwar
Copy link

Confirmed, same issue

@tractorcow
Copy link
Contributor

tractorcow commented Nov 3, 2017

Chosen has been shifted to admin now (not framework), but the image is only in the non-exposed admin/client/src/images folder.

We should move that to dist and make sure it's used by chosen dropdown in the CMS.

@tractorcow
Copy link
Contributor

Logged on admin module at silverstripe/silverstripe-admin#339

@flamerohr
Copy link

Pull request made which makes chosen-sprite.png available in admin's dist folder :)
Reference on here will need to be updated to match

@tractorcow
Copy link
Contributor

Ok, it's public now silverstripe/silverstripe-admin#353

Need to update this module with the new path.

@robbieaverill
Copy link
Contributor

I'm going to close this since we're going to be replacing the tag field rendering with a React based equivalent which will be controlled by the admin module in terms of styling/design. Doing that would make this issue obsolete. Since that issue is in progress at #110, doing this would be wasted effort.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants