Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

TODO: Investigate should GridFieldComponents change behaviour based on whether others are available in the config #69

Closed
sabina-talipova opened this issue Oct 12, 2023 · 1 comment
Closed

TODO: Investigate should GridFieldComponents change behaviour based on whether others are available in the config #69

sabina-talipova opened this issue Oct 12, 2023 · 1 comment

Comments

@sabina-talipova
Copy link
Contributor

sabina-talipova commented Oct 12, 2023 •
edited
Loading

Description

GridFieldExportReportButton::generateExportFileData(): Investigate should GridFieldComponents change behaviour based on whether others are available in the config.
See:

silverstripe-securityreport/src/Forms/GridFieldExportReportButton.php

Line 63 in de1a170

// @todo should GridFieldComponents change behaviour based on whether others are available in the config?

This was referenced Oct 12, 2023
Merged
Closed
@GuySartorelli
Copy link
Member

Gonna close this one - it's been working fine and any change to this would likely be part of a wider review of GridField itself. For now there's not much (if any) value looking at this one usage.

@GuySartorelli GuySartorelli closed this as not planned Won't fix, can't repro, duplicate, stale Oct 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@GuySartorelli @sabina-talipova