MNT Use React Testing Library #496
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3 tasks
emteknetnz
force-pushed
the
pulls/5.0/react-testing-library
branch
11 times, most recently
from
38dbe99 to
3cd8019
Compare
emteknetnz
force-pushed
the
pulls/5.0/react-testing-library
branch
from
3cd8019 to
f898421
Compare
emteknetnz
force-pushed
the
pulls/5.0/react-testing-library
branch
3 times, most recently
from
e457c37 to
2dd6201
Compare
emteknetnz
commented
May 2, 2023
| @@ -1,191 +0,0 @@ | |||
| /* global jest, describe, it, expect */ | |||
There was a problem hiding this comment.
I simply can't find a way to test this using react testing library
emteknetnz
force-pushed
the
pulls/5.0/react-testing-library
branch
2 times, most recently
from
7025952 to
579b5c8
Compare
GuySartorelli
requested changes
May 3, 2023
client/src/components/FormField/RegisteredMFAMethodListField/AccountResetUI.js
Show resolved
Hide resolved
client/src/components/FormField/RegisteredMFAMethodListField/MethodListItem.js
Show resolved
Hide resolved
client/src/components/FormField/RegisteredMFAMethodListField/RegisteredMFAMethodListField.js
Show resolved
Hide resolved
client/src/components/FormField/RegisteredMFAMethodListField/tests/AccountResetUI-test.js
Outdated
Show resolved
Hide resolved
emteknetnz
force-pushed
the
pulls/5.0/react-testing-library
branch
2 times, most recently
from
d430bd6 to
ee34c44
Compare
emteknetnz
force-pushed
the
pulls/5.0/react-testing-library
branch
from
ee34c44 to
d394fa6
Compare
GuySartorelli
approved these changes
May 3, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue silverstripe/silverstripe-admin#1506