Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Screen jumps up on rerender of MultiLinkField #169

Closed
emteknetnz opened this issue Jan 11, 2024 · 0 comments
Closed

Screen jumps up on rerender of MultiLinkField #169

emteknetnz opened this issue Jan 11, 2024 · 0 comments
Assignees
Labels

Comments

@emteknetnz
Copy link
Member

emteknetnz commented Jan 11, 2024

When you have a number of Links in a MultiLinkField and the LinkField react component rerenders creating an AJAX request to refetch Links, and for a short time the amount of vertical space taken up by the component reduces and it causes the browser screen to abruptly move up, loosing the users place on the screen

https://www.youtube.com/watch?v=HPimduM7bRU

This is because we render the loading component instead of the list of links.
We should instead wash out the link list and display the loading component on top of it. This will retain all of the rendered content while we're loading (preventing this scroll jump), and makes it a lot clearer what specifically is loading.

PRs

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants