Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GraphQL 4: JSON object type should be core #321

Open
unclecheese opened this issue Nov 12, 2020 · 2 comments
Open

GraphQL 4: JSON object type should be core #321

unclecheese opened this issue Nov 12, 2020 · 2 comments

Comments

@unclecheese
Copy link

silverstripe-elemental uses an "ObjectType" to handle their denormalised blockSchema field for arbitrary JSON. Seems like a pretty common need, and we should just build this into the global schema, as something more specific, like JSONType.

@sirtoobii
Copy link

@unclecheese I think this issue can be closed as JSONBlob is defined here:

JSONBlob:
serialiser: 'SilverStripe\GraphQL\Schema\Resolver\JSONResolver::serialise'
valueParser: 'SilverStripe\GraphQL\Schema\Resolver\JSONResolver::parseValue'
literalParser: 'SilverStripe\GraphQL\Schema\Resolver\JSONResolver::parseLiteral'

@unclecheese
Copy link
Author

Correct

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants