Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PSR-2 compliance #220

Open
robbieaverill opened this issue Jun 15, 2018 · 0 comments
Open

PSR-2 compliance #220

robbieaverill opened this issue Jun 15, 2018 · 0 comments

Comments

@robbieaverill
Copy link
Contributor

With #219 I've added a separate phpcs ruleset to this module, based on the framework's ruleset at the time with the exclusions removed that weren't actually failing here.

We should be aiming for PSR-2 compliance. The common exclusions in modules are camel caps method and class names since SilverStripe core requires them at times.

Current rules that should be removed easily enough:

<exclude name="Generic.Files.LineLength.TooLong"/>
<exclude name="PSR2.Methods.MethodDeclaration.Underscore"/> (note: semver!)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants