Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

datefield unusable in safari and locale nl_BE and nl_NL #8631

Closed
guyvanbael opened this issue Nov 23, 2018 · 8 comments
Closed

datefield unusable in safari and locale nl_BE and nl_NL #8631

guyvanbael opened this issue Nov 23, 2018 · 8 comments

Comments

@guyvanbael
Copy link

guyvanbael commented Nov 23, 2018

Affected Version: ss 4

  • no datepicker is showing up in safari
  • when contentlocal is nl_NL or nl_BE any selected date doesn't pass validation. It is always considered not a valid date. The form can't be submitted which is a real dealbreaker...
@guyvanbael guyvanbael changed the title datefield unusable in safari and local nl datefield unusable in safari and locale nl_BE and nl_NL Nov 23, 2018
@guyvanbael
Copy link
Author

same thing on de_DE
silverstripe/silverstripe-userforms#829 (comment)

@DorsetDigital
Copy link
Contributor

The first part of the issue isn't directly a SS problem. SS4 uses a native HTML5 input for dates, and I don't believe that Safari actually renders one. You may need to use a plugin such as the silverware calendar to get around that part.

@guyvanbael
Copy link
Author

guyvanbael commented Nov 23, 2018

IMHO something like this should have some kind of fallback for browsers that don't support this.
Dates show up in every website....
And as for the second issue... that's even a bigger problem for multilingual sites...

@guyvanbael
Copy link
Author

it's probably an issue for userforms, because using the datefield in the cms is working as expected (except for the fact that safari is not rendering a datepicker)

@chillu
Copy link
Member

chillu commented Dec 11, 2018

The idea was that the fallback is a text field. We're not going to deal with a JS library for date picking on top of the increasingly native capabilities, that's been a conscious decision during 4.x development. But we need to ensure authors know what format to use to write a date into a text field (e.g. no ambiguity around short vs. long month names)

@lerni
Copy link
Contributor

lerni commented Dec 19, 2018

@chillu
Copy link
Member

chillu commented Jan 28, 2019

@bergice Do you think this is still an issue?

@bergice bergice self-assigned this Jan 31, 2019
@bergice
Copy link
Contributor

bergice commented Feb 1, 2019

@chillu The validation issue should be resolved (silverstripe/silverstripe-userforms#829 (comment)) and I can't replicate it.

Also looks like we won't be adding a datepicker library so I'm closing this.

@bergice bergice closed this as completed Feb 1, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants