Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add port handling to TrustedProxyMiddleware #8252

Open
ScopeyNZ opened this issue Jul 10, 2018 · 1 comment
Open

Add port handling to TrustedProxyMiddleware #8252

ScopeyNZ opened this issue Jul 10, 2018 · 1 comment
Labels
affects/v4 complexity/low impact/low type/enhancement

Comments

@ScopeyNZ
Copy link
Contributor

ScopeyNZ commented Jul 10, 2018 •
edited
Loading

Currently the TrustedProxyMiddleware determines the forwarded host, IP and scheme (protocol). An additional attribute which might be forwarded is the port ($_SERVER['SERVER_PORT'] / $_SERVER['HTTP_X_FORWARDED_PORT']).

We should add this as some integrations (like SAML) might require host details including the port.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
affects/v4 complexity/low impact/low type/enhancement
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@dhensby @ScopeyNZ @emteknetnz