Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"Insert image" doesn't work on uploaded images #6520

Closed
chillu opened this issue Jan 17, 2017 · 3 comments
Closed

"Insert image" doesn't work on uploaded images #6520

chillu opened this issue Jan 17, 2017 · 3 comments

Comments

@chillu
Copy link
Member

chillu commented Jan 17, 2017

image

Breaks if you upload from the "insert image" dialog and select the image straight away. It should also select the image by default, since "upload within insert image dialog" is a pretty strong indication that you're about to insert it ;)

@jaylou
Copy link

jaylou commented Jan 17, 2017

Having the same issue using dev-master in Chromium 55.0.2883.87 and Firefox 50.1.0, both on Ubuntu 16.04 (64-bit). The file will upload but the first time you click Insert file, it will come up with an error.

Chromium showed this, the same as the one in your original post:
screenshot from 2017-01-18 11-56-07
Firefox gave me this one:
screenshot from 2017-01-18 11-48-25

Both of them inserted the file without complaint the second time I hit the button. I haven't been able to figure out what's causing the error or what might be causing SilverStripe to produce different messages in different browsers.

@zacps
Copy link
Contributor

zacps commented Jan 19, 2017

This is a manifestation of silverstripe/silverstripe-graphql#14.

@flamerohr
Copy link
Contributor

Just tested this on dev-master and it doesn't seem like this is an issue anymore, I've also checked the part of the code that has caused this error to occur and seems that has been patched up as well :D
https://github.com/silverstripe/silverstripe-asset-admin/blob/master/client/src/entwine/TinyMCE_ssmedia.js#L214

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants