Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PasswordField inside ConfirmedPasswordField isn't correctly marked as "required" #11098

Closed
GuySartorelli opened this issue Dec 19, 2023 · 2 comments

Comments

@GuySartorelli
Copy link
Member

GuySartorelli commented Dec 19, 2023

Affected Version

4.x, 5.x

Description

If you set the ConfirmedPasswordField as a required field, or if it's required due to its own validation logic (i.e. it can't be an empty value), the child fields aren't marked as required (i.e. they don't have the required="required" and aria-required="true" attributes).

These are required for accessibility and for any front-end validation developers choose to implement.

PRs

@sabina-talipova
Copy link
Contributor

PR's merged. It will be automatically tagged in next CI round.

@GuySartorelli
Copy link
Member Author

^ FYI @purplespider

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants