Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TODO: Update CheckboxSetField documentation #11000

Closed
sabina-talipova opened this issue Oct 18, 2023 · 1 comment
Closed

TODO: Update CheckboxSetField documentation #11000

sabina-talipova opened this issue Oct 18, 2023 · 1 comment

Comments

@sabina-talipova
Copy link
Contributor

Description

Document the different source data that can be usedwith this form field - e.g ComponentSet, SQLMap, ArrayList, array. Is it also appropriate to accept so many different types of data when just using an array would be appropriate?

See: https://github.com/silverstripe/silverstripe-framework/blob/cf78a9d785b9959a92dfb52c2a456bea80a4c567/src/Forms/CheckboxSetField.php#L40C1-L43C64

@GuySartorelli
Copy link
Member

Closing this - we have a lot of formfields like this which can take many different types of data. We don't need to be more specific than we already have been imo, at least not until we're looking at typehinting them which we'll do holistically.

@GuySartorelli GuySartorelli closed this as not planned Won't fix, can't repro, duplicate, stale Oct 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants