Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Debug: provide an option to _not_ call die() #10997

Open
sabina-talipova opened this issue Oct 18, 2023 · 2 comments
Open

Debug: provide an option to _not_ call die() #10997

sabina-talipova opened this issue Oct 18, 2023 · 2 comments

Comments

@sabina-talipova
Copy link
Contributor

sabina-talipova commented Oct 18, 2023

Description

  • Add support for user defined config: Debug::die_on_notice(bool).

The Debug::endshow() method calls die() at the end. Various other methods such as dump() do not.
We should provide a way for the developer to decide whether they want to call die() or not, perhaps via a new static such as dieOnNotice() which accepts a bool, and the bool determines if the methods should call die() or not.

See:

* @todo add support for user defined config: Debug::die_on_notice(true | false)
* @todo better way of figuring out the error context to display in highlighted source

@GuySartorelli
Copy link
Member

@sabina-talipova Do you know what is intended by either of those todo notes? I'm not sure what is intended and wouldn't know how to implement this.
If you have more context please add it - otherwise this might be one we should close.

@sabina-talipova
Copy link
Contributor Author

I've updated ticket. I'm not quite sure, should we provide some sort of functionality to user. It's just how I understood this todo comment.
If you think it's not necessary we can close this issue.

@GuySartorelli GuySartorelli changed the title TODO: Debug::die_on_notice config Debug: provide an option to _not_ call die() Oct 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants