You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Add support for user defined config: Debug::die_on_notice(bool).
The Debug::endshow() method calls die() at the end. Various other methods such as dump() do not.
We should provide a way for the developer to decide whether they want to call die() or not, perhaps via a new static such as dieOnNotice() which accepts a bool, and the bool determines if the methods should call die() or not.
@sabina-talipova Do you know what is intended by either of those todo notes? I'm not sure what is intended and wouldn't know how to implement this.
If you have more context please add it - otherwise this might be one we should close.
I've updated ticket. I'm not quite sure, should we provide some sort of functionality to user. It's just how I understood this todo comment.
If you think it's not necessary we can close this issue.
GuySartorelli
changed the title
TODO: Debug::die_on_notice config
Debug: provide an option to _not_ call die()Oct 29, 2023
Description
Debug::die_on_notice(bool)
.The
Debug::endshow()
method callsdie()
at the end. Various other methods such asdump()
do not.We should provide a way for the developer to decide whether they want to call
die()
or not, perhaps via a new static such asdieOnNotice()
which accepts a bool, and the bool determines if the methods should calldie()
or not.See:
silverstripe-framework/src/Dev/Debug.php
Lines 29 to 30 in cf78a9d
The text was updated successfully, but these errors were encountered: