-
Notifications
You must be signed in to change notification settings - Fork 824
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Provide better feedback when using CsvBulkLoader #10996
Comments
@sabina-talipova The description doesn't seem related to the issue title or the links - can you please check this one? I think it got mixed up with #10995 |
|
Sounds like a plan |
Sorry, I copied description from another ticket by accident. I've update description again. I reopen ticket. |
Description
We pass message as empty string in
BulkLoader_Result::addUpdated
fromCsvBulkLoader::processRecord
(See). We must pass a more clear message to theaddUpdated
method, or delete this variable fromprocessRecord
, since the methodaddUpdated
usesnull
by default.See:
silverstripe-framework/src/Dev/CsvBulkLoader.php
Line 163 in cf78a9d
silverstripe-framework/src/Dev/CsvBulkLoader.php
Line 264 in cf78a9d
Note that this message is (or is supposed to be) displayed in the form modal which is used to trigger the bulk action.
The text was updated successfully, but these errors were encountered: