Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ViewableDataContains::toString - add representation for more than one match #10990

Closed
sabina-talipova opened this issue Oct 17, 2023 · 1 comment
Closed

ViewableDataContains::toString - add representation for more than one match #10990

sabina-talipova opened this issue Oct 17, 2023 · 1 comment
Labels
impact/low type/enhancement

Comments

@sabina-talipova
Copy link
Contributor

Description

ViewableDataContains::toString returns the first element of the current $this->match array. Add representation if $this->match array contains more than one element.

See:

silverstripe-framework/src/Dev/Constraint/ViewableDataContains.php

Line 78 in cf78a9d

* @todo: add representation for more than one match

This was referenced Oct 17, 2023
Closed
Merged
@GuySartorelli GuySartorelli changed the title TODO: ViewableDataContains::toString - add representation for more than one match ViewableDataContains::toString - add representation for more than one match Oct 25, 2023
@GuySartorelli
Copy link
Member

Gonna close this one - we're not likely to get around to doing it.

@GuySartorelli GuySartorelli closed this as not planned Won't fix, can't repro, duplicate, stale Oct 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
impact/low type/enhancement
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@GuySartorelli @sabina-talipova