Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed fields are hardcoded in DataQuery::getFinalisedQuery() - but is configurable on DataObject. #10958

Closed
GuySartorelli opened this issue Sep 25, 2023 · 1 comment
Closed

Fixed fields are hardcoded in DataQuery::getFinalisedQuery() - but is configurable on DataObject. #10958

GuySartorelli opened this issue Sep 25, 2023 · 1 comment
Labels
affects/v4 affects/v5 impact/low type/bug

Comments

@GuySartorelli
Copy link
Member

GuySartorelli commented Sep 25, 2023 •
edited
Loading

DataObject.fixed_fields is configurable. It is extremely edge-case to want to modify the values in this array, but since it's configurable, we need to respect the configuration and not hard code references to these fields when they are meant to be treated uniformly.

PRs
@GuySartorelli GuySartorelli mentioned this issue Sep 25, 2023
Merged
@sabina-talipova
Copy link
Contributor

PR's merged. It will be automatically tagged in next CI round.

@sabina-talipova sabina-talipova removed their assignment Sep 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
affects/v4 affects/v5 impact/low type/bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@GuySartorelli @sabina-talipova