Deprecation notices wrapped in Deprecation::withNoReplacement() are logged as NameSpace\{closure}

[GuySartorelli]

For some deprecated API we have explicitly wrapped the notice in a call to Deprecation::withNoReplacement() - e.g.

silverstripe-framework/src/ORM/Connect/Query.php

Lines 200 to 207 in ab566b0

	return Deprecation::withNoReplacement(function () {
	Deprecation::notice('4.13.0', 'Will be replaced by getIterator() in CMS 5');
	if (!$this->currentRecord) {
	return $this->next();
	} else {
	return $this->currentRecord;
	}
	});

This results in the deprecation warning in logs appearing like so:

SilverStripe\ORM\Connect\Query->SilverStripe\ORM\Connect{closure} is deprecated. Will be replaced by getIterator() in CMS 5. Called from SilverStripe\ORM\Connect\Query->column.

Instead of {closure}, it should say the actual method and class which are deprecated.

This is made complicated however by the fact that sometimes we use Deprecation::withNoReplacement() to wrap the call to deprecated API instead of wrapping the notice directly. In those cases the logs already correctly identify the deprecated API.

Acceptance criteria

• All deprecated API is correctly identified, regardless of whether and how it's wrapped in Deprecation::withNoReplacement()
  OR
• All deprecated API is correctly identified, and we use different mechanisms to wrap noticed than we do to wrap calls to deprecated API

PRs

• FIX Correctly identify deprecated API in withNoReplacement #10706