Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove deprecated code in CMS 5 for kitchen-sink #10546

Closed
5 of 6 tasks
emteknetnz opened this issue Oct 12, 2022 · 1 comment
Closed
5 of 6 tasks

Remove deprecated code in CMS 5 for kitchen-sink #10546

emteknetnz opened this issue Oct 12, 2022 · 1 comment
Assignees
@GuySartorelli
Labels
affects/v5 complexity/low impact/low type/api-break

Comments

@emteknetnz
Copy link
Member

emteknetnz commented Oct 12, 2022 •
edited by GuySartorelli
Loading

silverstripe/recipe-kitchen-sink version of #10501

The follow following for all non-silverstripe/installer modules in silverstripe/recipe-kitchen-sink

Acceptance criteria

  • Code from the 1/4 branches is merged-up first
  • All deprecated code is removed for all supported modules
  • All unit tests covering deprecated code are removed
  • YML Config is reviewed to make sure it doesn't reference removed code
  • A list of all deprecated methods and classes is added to the CMS5 changelog to help people plan their upgrades
  • The Serializable interface is removed from classes, along with deprecated serialize() and unserialize() methods

PRs

Subsites

Blocked PR's

Require additional actions
@emteknetnz emteknetnz self-assigned this Oct 12, 2022
@maxime-rainville maxime-rainville mentioned this issue Oct 16, 2022
Closed
3 tasks
@emteknetnz emteknetnz removed their assignment Dec 6, 2022
@sabina-talipova sabina-talipova self-assigned this Dec 15, 2022
@sabina-talipova sabina-talipova mentioned this issue Dec 16, 2022
Merged
This was referenced Jan 17, 2023
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Closed
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
@sabina-talipova sabina-talipova removed their assignment Jan 24, 2023
This was referenced Jan 25, 2023
Merged
Merged
@emteknetnz emteknetnz mentioned this issue Jan 26, 2023
Merged
@GuySartorelli
Copy link
Member

All merged

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@GuySartorelli GuySartorelli

Labels
affects/v5 complexity/low impact/low type/api-break
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@emteknetnz @GuySartorelli @sabina-talipova