Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove PDO from the codebase (still needs docs changes) #10498

Closed
4 of 7 tasks
GuySartorelli opened this issue Sep 9, 2022 · 1 comment
Closed
4 of 7 tasks

Remove PDO from the codebase (still needs docs changes) #10498

GuySartorelli opened this issue Sep 9, 2022 · 1 comment

Comments

@GuySartorelli
Copy link
Member

GuySartorelli commented Sep 9, 2022

PDO has been deprecated since the acceptance of this RFC. See deprecation notice.

Remove the deprecated PDO code from postgres and update docs

Acceptance criteria

  • The relevant PDO code is removed from silverstripe/postgresql
  • The changelog notes the removal of PDO
  • Any documentation that mentions PDO has been updated

====

Already achieved acceptance criteria

  • There is an appropriate deprecation notice in case someone tries to use PDO
  • CMS 5 has no code related to PDO
  • CMS 5 CI doesn't include a PDO run
  • CMS 4 CI still includes a PDO run

Already merged PRs

PRs

@GuySartorelli
Copy link
Member Author

Reopening this - we still need to do the docs changes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants