-
Notifications
You must be signed in to change notification settings - Fork 823
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
PHP 8.1 Tidy up #10294
Labels
Comments
This was referenced Apr 27, 2022
This was referenced Apr 29, 2022
PRs are merged, but there is an acceptance criterion that can't be ticked off until the cow beta release either does or does not update |
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Parent issue for pull-requests to tidy up PHP 8.1 work
TODO
Notes on trying to get travis ci to fail on deprecations:
Depite this PR - we still have green jobs with deprecation warnings
I don't think we can get phpunit to properly fail on deprecation notices - I've tried the following custom error handler in
SapphireTest.php
along with--fail-on-warning
However tests are still green despite the presence of
Warning: strtoupper(): Passing null to parameter #1 ($string) of type string is deprecated
I've also tried updating
phpunit.xml.dist
- https://phpunit.readthedocs.io/en/9.5/configuration.html - howeverfailOnWarning="true"
which is equally useless as--fail-on-warning
andconvertDeprecationsToExceptions="true"
is too brutal and causes phpunit to exitPRs
The text was updated successfully, but these errors were encountered: