Inline form fields need to be psuedo-namespaced

[robbieaverill]

With #372 all form fields for inline element editing are given HTML names from their element, e.g. Title, HTML etc.

This not only conflicts between elements but also with the page that the forms sit in. Changing a basic content block's Title then overrides the page's Title when saving (#328).

I propose that we prefix element CMS field names with something unique to them, e.g.:

- input type="text" name="Title"
+ input type="text" name="PageElements[123][Title]"

Where 123 is the element's ID

Pull requests

• FIX Add namespaces to inline edit form field names #386

[robbieaverill]

Hmmm. Renaming the fields and getting them into the Redux form's state is easy enough, but redux-form won't render the value for the form field if the name is an array for some reason.

[robbieaverill]

I suspect the bug is in how admin converts the form state into something that redux will accept - i.e. form fields like Foo[123][Bar] are added to the state as "Foo[123][Bar]": "value here" but maybe should be nested in the state e.g. "foo": { "123": { "bar": "value here" } } }. I notice that updating the form after its loaded (empty) attempts to change the state to what something more like that.

A workaround we could entertain would be using Foo_123_Bar and serialising the (redux) form state into a hidden field, where the keys are rewritten to what they should be

[robbieaverill]

WIP PR: https://github.com/creative-commoners/silverstripe-elemental/tree/pulls/4.0/namespaced-fields

This is working, but using underscored names rather than arrays. If we choose to go this route we'd need to serialise the form data as mentioned above. Another expensive option would be that the page loads its elements and all CMS fields for each element then looks for each field in the request data explicitly... =/

[robbieaverill]

Interim solution PR at #386