Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Convert ElementalEditor GridField to a React based equivalent #272

Closed
26 tasks done
robbieaverill opened this issue Jul 29, 2018 · 2 comments
Closed
26 tasks done

Convert ElementalEditor GridField to a React based equivalent #272

robbieaverill opened this issue Jul 29, 2018 · 2 comments

Comments

@robbieaverill
Copy link
Contributor

robbieaverill commented Jul 29, 2018

Prior to beginning work on inline editing of content blocks, we'll need to:

Create a new react app - e.g. ElementalEditor and power as much of this with React, GraphQL and form factory/schema as possible now to pave the way for the react driven CMS in future.

We don't need to continue using gridfield for elemental, particularly because the editor only really has one column.

Acceptance criteria

Subtasks

@robbieaverill
Copy link
Contributor Author

Clarification on an acceptance criteria point:

(A/C) Page will have one elemental area

Elemental currently supports multiple elemental areas per page, but only provides one out of the box.

We'll implement this in a way that works for the default ElementalArea relationship, but attempt to document how devs can add more elemental editors for extra relationships they want to add.

It's unlikely to be as easy as it was with PHP GridFields.

@robbieaverill
Copy link
Contributor Author

Edit ability (via GridFieldDetailForm) still works

We looked at removing GridField as a backend as part of this work, but until we have a React replacement for an edit form we'll need to keep it there to support blocks that won't be able to be edited inline (such as userform blocks).

For more info, see silverstripe/silverstripe-admin#590

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants