MNT Use React Testing Library #107
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3 tasks
GuySartorelli
requested changes
Apr 28, 2023
Comment on lines
26
to
28
| expect(container.querySelector('.block-link-field__icon')).not.toBeNull() | ||
| expect(container.querySelector('.block-link-field__content')).not.toBeNull() | ||
| expect(container.querySelector('.block-link-field__actions')).not.toBeNull() |
There was a problem hiding this comment.
Should check for exactly one of each as per original test. This probably applies to other tests in this PR.
Comment on lines
+93
to
+103
| test('BlockLinkField returns empty string if no relative URL provided', () => { | ||
| const { container } = render( | ||
| <BlockLinkField {...makeProps({ | ||
| linkedPage: {}, | ||
| })} | ||
| /> | ||
| ); | ||
| expect(container.querySelector('.block-link-field__link')).toBeNull(); | ||
| }); |
There was a problem hiding this comment.
An element with no text inside (empty string) and simply not having an element are not the same thing. I accept that you can't test the internal function from the original test anymore, but we need to update the title to describe what we're actually testing now.
client/src/components/BlockLinkField/tests/BlockLinkField-test.js
Outdated
Show resolved
Hide resolved
emteknetnz
force-pushed
the
pulls/3.0/react-testing-library
branch
from
fbd9c43 to
a11b74b
Compare
emteknetnz
force-pushed
the
pulls/3.0/react-testing-library
branch
from
a11b74b to
a377fc2
Compare
GuySartorelli
approved these changes
May 2, 2023
14 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue silverstripe/silverstripe-admin#1419