Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

it takes a lot of clicks and it is hard to find "view" / "download" link. #947

Closed
1 task done
sunnysideup opened this issue May 26, 2019 · 8 comments
Closed
1 task done

Comments

@sunnysideup
Copy link

sunnysideup commented May 26, 2019

In the asset admin, it is not very intuitive for me to find the file's download link (PDF). Also, the icon shown on mouse-over for the download link is a zoom in icon. This is also confusing to me. I would recommend:

  1. the edit pane shows the actual link that you can click on to open / download a file.

  2. you can open / download the file directly from the tiles.

  3. the zoom-in icon is replaced with the eye or a download icon.

Pull Requests

@maxime-rainville
Copy link
Contributor

If you don't have CMS open in front of you https://youtu.be/cQESdH36H-Q

I think the Zoom-in icon is there because when you click on an image it will allow you to see the full-resolution version.

That doesn't make much sense when you don't have an actual thumbnail there or when the file can't actually be viewed in your browser.

@maxime-rainville
Copy link
Contributor

@silverstripeux

@kinglozzer
Copy link
Member

Agreed, it’s definitely too hard to find!

Semi-related issue (downloading files from UploadField directly): #822

@clarkepaul
Copy link
Contributor

Yup agree these are half implementations of the design so not very well executed. The magnifying glass was supposed to open images in a modal and not it a new tab. It also depends on what you're trying to view and how your browser is configured as to whether something is downloaded. It was originally designed with a full URL link underneath the location (folder) field. A lot of these things happen because of an MVP state, but also things have also progressed since the original designs so it would need new designs done.

I think the magnifying action should still remain but could be improved by having it open in a modal for images, for other non-viewable files it could be a download icon instead.
A download icon might be better placed at the end of the URL (there was supposed to be a download link in the "more options" (...) dropdown but that also never happened as planned).

Question: is having a download link in the "more options" dropdown enough of a step forward or does the location field require the full URL underneath it as per the original plans.

@sunnysideup
Copy link
Author

Hi Paul,

I think we can perhaps simplify this by showing a full link to the file that people can click on. That will work for both downloads and non-downloads (images). That is simple to implement and i'd rather see that added than something more fancy never getting added.

@clarkepaul
Copy link
Contributor

That's what the design was (a simple link showing full URL) attached to the location field. Would you be keen to implement it? It's just that with the current impact level it's not going to be a priority (same as why it didn't get implemented in the first place). If so we can supply guidance with design.

@newleeland
Copy link

newleeland commented Aug 23, 2019

It would be good to use a similar experience as UploadField dropdown options shown here:
https://projects.invisionapp.com/dsm/silver-stripe/silver-stripe/asset/components/5b5e6e3984472000117f3ee4

If we have a path with the download link, I think it would be too long for the sidebar and it would look unsightly.

The suggestion is to add this to the meatballs menu, next to the save and publish icons.

@brynwhyman brynwhyman added this to the Sprint 44 milestone Sep 17, 2019
@bergice bergice assigned bergice and unassigned bergice Sep 20, 2019
@brynwhyman brynwhyman modified the milestones: Sprint 44, Sprint 45 Oct 1, 2019
@bergice bergice removed their assignment Oct 2, 2019
@maxime-rainville maxime-rainville self-assigned this Oct 7, 2019
@maxime-rainville
Copy link
Contributor

This issue has been worked on as part of a larger initiative focused on reducing the experience debt of the SilverStripe CMS.

Thank you for taking the time to raise this issue and/ or provide feedback supporting the implementation.

This is an initiative from the teams maintaining the commercially supported module list. If you're interested to read more about this initiative and keep up with our progress have a look at our blog post on experience debt.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

7 participants