Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CMS remembers tab selection, file "used on" doesn't fire when loaded as 'active' tab #1423

Open
jules0x opened this issue Nov 23, 2023 · 2 comments

Comments

@jules0x
Copy link

jules0x commented Nov 23, 2023

A client reported an issue seeing the "used on" information of a file, and indicated they had to click away and back again to see it.

Files are not immediately showing where they are in use. They will show as not in use anywhere even if they are. It takes selecting them multiple times for them to show where they are in use.

I tested this on their project, then confirmed there is an issue on a fresh project using composer create-project silverstripe/installer test

  • Select a file and click the “used on” tab: the usage shows correctly
  • Select a second file: no usage shows (noting that the “used on” tab is active as it was the most recent tab on the previous file)
    • Click back to “details”, then back to “used on”: the usage shows correctly
  • Select a third file: no usage shows (noting that the “used on” tab is active)
    • Click to another file, then back again: usage shows correctly
    • Click back to the “details” tab
  • Select a fourth file and click “used on: the usage shows correctly (noting that the "details" tab is active)

It appears the “usage” request is triggered by the click on the “used on” tab, or when returning to the file. The effect of this is that the usage will be retrieve when you’ve arrived onto a file and “details” is the active tab, but if “used on” is the active tab, then you’ll need to switch tabs and back, or switch files and back.

"name": "silverstripe/asset-admin",
"version": "2.1.2",

@GuySartorelli
Copy link
Member

Hi,

Thank you for reporting this. Do you know if this affects version 1.x of this module as well? Or only 2.x?

We have a large backlog at the moment, so this bug likely won't be prioritised by the CMS Squad for a long time. If you'd like to give a go at fixing it we'd love to review a pull request.

@jules0x
Copy link
Author

jules0x commented Dec 3, 2023

Unsure if affects 1.x

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants