Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TODO: Refactor "queued files" into separate visual area and remove coupling here #1407

Closed
sabina-talipova opened this issue Oct 17, 2023 · 3 comments

Comments

@sabina-talipova
Copy link
Contributor

Description

We should refactor "queued files" into separate visual area and remove coupling in some functions in asset admit.

  • handleMoveFilesSuccess. See
  • mapStateToProps. See
  • mapDispatchToProps. See
@GuySartorelli
Copy link
Member

@sabina-talipova What are "queued files" and what would a separate visual area be like?
I think this is one of those issues where we don't have enough context and should probably close it.

@sabina-talipova
Copy link
Contributor Author

I left this TODO comment, because I think that the main idea here was to extract queuedFiles and all related logic into additional Component.
But if you think that we are not going to spend time on this enhancement we can close this ticket.

@GuySartorelli
Copy link
Member

I think the status quo is probably okay for now - we're not likely to spend time on this in the foreseeable future.

@GuySartorelli GuySartorelli closed this as not planned Won't fix, can't repro, duplicate, stale Oct 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants