remote content (YouTube videos) are uneditable and break the CMS when if a video is removed

[NightJar]

If one has a page, and that page embeds a YouTube video via the media button in the WYSIWYG, this is good.
Until the video expires for whatever reason.
In this case if one wishes to edit the embed to insert a new valid video link it results in a broken modal that never loads.

silverstripe-asset-admin/code/Extensions/RemoteFileModalExtension.php

Lines 99 to 120 in 1204ac2

	public function remoteEditFormSchema(HTTPRequest $request)
	{
	$schemaID = $request->getURL();
	try {
	$form = $this->remoteEditForm();
	return $this->getSchemaResponse($schemaID, $form);
	} catch (NetworkException | RequestException | InvalidRemoteUrlException $exception) {
	$errors = ValidationResult::create()
	->addError($exception->getMessage());
	// @todo - Don't create dummy form (pass $form = null)
	$form = Form::create(null, 'Form', FieldList::create(), FieldList::create());
	$code = $exception->getCode();
	if ($code < 300) {
	$code = 500;
	}
	return $this
	->getSchemaResponse($schemaID, $form, $errors)
	->setStatusCode($code);
	}
	}

By design the controller action returns HTTP 500, which is not handled by the client (on the front end).
In the least a very confused and frustrated content editor.
In the worst, javascript errors and a non-functioning CMS. (unconfirmed, can't remember)

Test case: https://www.youtube.com/watch?v=IvTJ3cRzVbc

PRs

• ENH Do not show loading spinner when there was a loading error silverstripe-admin#1574

[sabina-talipova]

PR merged. Issue was solved. This will be automatically tagged. Close.