Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

STATE: Files embedded in TinyMCE remain marked as draft after Page is published #1001

Open
NightJar opened this issue Sep 12, 2019 · 5 comments

Comments

@NightJar
Copy link
Contributor

When using TinyMCE to embed a file, selecting a draft asset from the store modal works as intended. However after publishing the page the asset in the store modal is still represented as being in draft (false information).

  1. Open a page with a TinyMCE field (e.g. Page) for editing in the CMS
  2. Click the "Insert Media" button on the TinyMCE toolbar
  3. Upload a new image and select it
  4. Publish the page
  5. Repeat step 2
  6. 👀 Observe that the file uploaded in step 3 is still represented in draft mode

Strongly related to #782
However from a different view.

@IsaacInsoll
Copy link

IsaacInsoll commented Oct 1, 2019

We have the same issue in SS4.4.2 where it seems that some images inserted into HTMLTextFields are getting saved but not published so when users refresh the CMS or try to view the content in the front end the images don't appear. If i view the HTML via phpMYAdmin I can see the ID of the image inside the tag and then find it and publish it which fixes the problem but obviously isn't easy to explain to CMS users.

I've temporarily solved this by building a BuildTask that finds all unpublished images and calls publishSingle() on them and running that whenever a user complains of missing images which is obviously nowhere near ideal.

@brynwhyman brynwhyman added this to the Sprint 46 milestone Oct 15, 2019
@brynwhyman
Copy link

brynwhyman commented Oct 20, 2019

FYI, I've just closed #782 as I couldn't recreate it in 1.4.x-dev. I could however still recreate this issue.

When navigating to the Files area and uploading a file, it appears to first trigger a refresh of the Files app (perhaps why #782 is fixed). That same refresh doesn't appear to happen when you upload a file after accessing the area through the "Insert Media" button on the TinyMCE toolbar.

There's a gif in #782 for more detail.

@emteknetnz
Copy link
Member

Related #960

@sachajudd
Copy link
Contributor

Related #543

@GuySartorelli
Copy link
Member

Related #1315

@GuySartorelli GuySartorelli changed the title Files embedded in TinyMCE remain marked as draft after Page is published STATE: Files embedded in TinyMCE remain marked as draft after Page is published Feb 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

6 participants