Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

React 16.8 #881

Open
dunatron opened this issue May 15, 2019 · 8 comments
Open

React 16.8 #881

dunatron opened this issue May 15, 2019 · 8 comments

Comments

@dunatron
Copy link

Any chance this module can be upgraded to use React 16.8?
This will allow developers to develop their SilverStripe CMS modules with hooks.

@robbieaverill
Copy link
Contributor

Hi @dunatron, we've updated to 16.6 in SilverStripe 4.4, so could probably update to 16.8 (or higher) in a newer minor release.

@dunatron
Copy link
Author

Hi @robbieaverill That would be fantastic!
I would recommend 16.8.6 and not the ^16.8 as it seems to cause a few issues and treats it as 16.7 which will not include hooks.

@ScopeyNZ
Copy link
Contributor

At a quick glance this looks pretty low impact going from 16.6->16.8. Would it be too unrealistic to try and get this in now while 4.4 is still a RC?

@unclecheese
Copy link

We've already released 4.4.0-RC, and while a minor upgrade for React may be low impact, it doesn't fit into the criteria of what we would put over the top of a published RC ahead of a stable release.

I love the idea of hooks, and I think we're all excited about them, but from what I've seen, there aren't too many cases where you can just replace them with their HOC counterparts.

Definitely 4.5, though!

@michalkleiner
Copy link
Contributor

It could be RC2, nah?

@ScopeyNZ
Copy link
Contributor

It could be RC2, nah?

We had a brief "offline" chat about this. @unclecheese correctly pointed out that RC is stabilisation time - we shouldn't add things that make the codebase less stable 😞

@dunatron
Copy link
Author

dunatron commented Mar 3, 2020

any chance on the react package getting a small bump?

@ScopeyNZ
Copy link
Contributor

ScopeyNZ commented Mar 3, 2020

This probably should've been done with 4.5 but probably wasn't prioritised. You're welcome to contribute a bump to the 4 branch - you'll have to test it a little and try it with a module that integrates heavily like asset-admin and/or elemental.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

6 participants