-
Notifications
You must be signed in to change notification settings - Fork 95
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
React 16.8 #881
Comments
Hi @dunatron, we've updated to 16.6 in SilverStripe 4.4, so could probably update to 16.8 (or higher) in a newer minor release. |
Hi @robbieaverill That would be fantastic! |
At a quick glance this looks pretty low impact going from 16.6->16.8. Would it be too unrealistic to try and get this in now while 4.4 is still a RC? |
We've already released 4.4.0-RC, and while a minor upgrade for React may be low impact, it doesn't fit into the criteria of what we would put over the top of a published RC ahead of a stable release. I love the idea of hooks, and I think we're all excited about them, but from what I've seen, there aren't too many cases where you can just replace them with their HOC counterparts. Definitely 4.5, though! |
It could be RC2, nah? |
We had a brief "offline" chat about this. @unclecheese correctly pointed out that RC is stabilisation time - we shouldn't add things that make the codebase less stable 😞 |
any chance on the react package getting a small bump? |
This probably should've been done with 4.5 but probably wasn't prioritised. You're welcome to contribute a bump to the |
Any chance this module can be upgraded to use React 16.8?
This will allow developers to develop their SilverStripe CMS modules with hooks.
The text was updated successfully, but these errors were encountered: