Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Modal close icon has no cursor change, and doesn't use icon library #548

Closed
clarkepaul opened this issue Jun 19, 2018 · 2 comments
Closed

Comments

@clarkepaul
Copy link
Contributor

clarkepaul commented Jun 19, 2018

The close icon on modals don't have a cursor change when you hover over the action. We should swap the close icon for one from the icon font library so it fits the rest of the UI (suggested classes: .btn .font-icon-cancel .btn--icon-xl .no-text).

pasted_image_19_06_18__3_14_pm

We've had a mention that the modal close action was hard to click, I've test this functionally myself and didn't see any issues but worth confirming again when this issue is picked up (perhaps through browser testing).

@sachajudd
Copy link
Contributor

@clarkepaul cursor change and font-icon is implemented. Just wondering if the hover here is meant to be blue?
close-modal

@clarkepaul
Copy link
Contributor Author

Nope shouldn't be blue, should be the same as the other icons.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants