ModelAdmin Search form MultiSelect field types submit javascript [object Object]

[christohill]

Module version(s) affected

5.2.22

Description

When adding a multi-select field type to a ModelAdmin search form through modifying the SearchContext in GridFieldFilterHeader, the multi-select field submits an string of comma separated javascript type objects ([object Object]).

I've tested this with ListboxField and TagField (silverstripe/tagfield) with similar results. Interestingly, CheckboxSetField which is also marked as php $schemaDataType = FormField::SCHEMA_DATA_TYPE_MULTISELECT submits a string of comma separated keys when an array is set as the source.

How to reproduce

Basic example

public function getGridField(): GridField {
    $grid = parent::getGridField();
    $filter = $grid->getConfig()->getComponentByType(GridFieldFilterHeader::class);
    $context = $filter->getSearchContext($grid);
    $fields = $context->getFields();
    $fields->add(ListboxField::create('Test', 'Test', ['one' => 'One', 'two' => 'Two']));

    return $grid;
}

Form Data Payload: filter[members][Test]: [object Object],[object Object]

Custom SearchContext Example

// ModelAdmin
public function getGridFieldConfig(): GridFieldConfig {
    $config = parent::getGridFieldConfig();
    $filter = $config->getComponentByType(GridFieldFilterHeader::class);
    $filter->setSearchContext(MemberSearchContext::create(Member::class));

    return $config
}

// MemberSearchContext
class MemberSearchContext extends SearchContext {

    public function getSearchFields() {
        $fields = parent::getSearchFields();
        $fields->add(ListboxField::create('Test', 'Test',  ['one' => 'One', 'two' => 'Two']));
        return $fields;
    }

    public function getQuery($data, $sort = false, $limit = false, $existingQuery = null) {
        $query = parent::getQuery($data, $sort, $limit, $existingQuery);
        // Dump form data
        echo "<pre>";
        var_dump($data);
        echo "</pre>";
        die();
        return $query;
    }
}

Possible Solution

No response

Additional Context

Validations

• Check that there isn't already an issue that reports the same bug
• Double check that your reproduction steps work in a fresh installation of silverstripe/installer (with any code examples you've provided)

[GuySartorelli]

Closing as a duplicate of #1746
If this issue provides additional context, please add that context to the original issue.