Re-login doesn't work as expected

[jules0x]

Module version(s) affected

2.2.14

Description

When a user has unsaved changes, and is idle for a period, the screen prompts for the users password.
When the user enters the password, nothing happens.
Clicking the link "refresh this page" loses the users unsaved changes,
It also shows an X at the top right, which does't do anything.

The interaction here should seamlessly refresh the session without interruption, allowing the user to continue editing or save.

Or is this the intended state?

Tested on a fresh install of silverstripe.

How to reproduce

Edit some content (e.g. HTMLEditorField).
Wait for idle timeout.
Press save.

Possible Solution

No response

Additional Context

No response

Validations

• Check that there isn't already an issue that reports the same bug
• Double check that your reproduction steps work in a fresh installation of silverstripe/installer (with any code examples you've provided)

[Cambis]

Done some investigation into this issue, it seems that the reauthentication is successful but the login modal doesn't close

How to reproduce

1. Login to the cms
2. Edit any page
3. Invalidate your session (easiest way to is to delete your php session cookie)
4. Click save
5. See the login modal prompt, fill in details and submit
6. See that the login modal does not close

At this point if I remove the modal from the DOM manually, I can edit and save the page as normal.

Possible solution

I'm not that familiar with how this library works but here's some ideas 😅

1. Check to see if there are multiple react root elements? Perhaps this line references a different react root when the modal is opened vs closed?

   silverstripe-admin/client/src/legacy/LeftAndMain.js

   Line 1070 in 8c1861c

   let root = this.getReactRoot();

2. Investigate using onUnmountClose and onClosed props to help remove the modal see https://reactstrap.github.io/?path=/docs/components-modal--modal#props

Additional context

I can confirm that the close function is being called as expected

silverstripe-admin/client/src/legacy/LeftAndMain.js

Line 1055 in 8c1861c

close() {