Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

TODO: FormBuilderLoader.getMessages - define standard message type #1602

Closed
sabina-talipova opened this issue Oct 17, 2023 · 1 comment
Closed

TODO: FormBuilderLoader.getMessages - define standard message type #1602

sabina-talipova opened this issue Oct 17, 2023 · 1 comment
Labels
affects/v5 type/enhancement

Comments

@sabina-talipova
Copy link
Contributor

sabina-talipova commented Oct 17, 2023 •
edited
Loading

Description

Define in FormBuilderLoader.getMessages() function message type as standard "success", "info", "warning" and "danger".
See:

silverstripe-admin/client/src/containers/FormBuilderLoader/FormBuilderLoader.js

Line 69 in 0f18b3d

// TODO define message type as standard "success", "info", "warning" and "danger"

@sabina-talipova sabina-talipova mentioned this issue Oct 17, 2023
Closed
@sabina-talipova sabina-talipova changed the title TODO: FormBuilderLoader.getMessages() - define standard message type TODO: FormBuilderLoader.getMessages - define standard message type Oct 17, 2023
@sabina-talipova sabina-talipova mentioned this issue Oct 17, 2023
Merged
@GuySartorelli
Copy link
Member

Closing as that would be detrimental to any custom types defined in project code

@GuySartorelli GuySartorelli closed this as not planned Won't fix, can't repro, duplicate, stale Oct 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
affects/v5 type/enhancement
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@GuySartorelli @sabina-talipova