Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

javascript cookies missing "SameSite" attribute #1413

Open
3 tasks
GuySartorelli opened this issue Dec 11, 2022 · 0 comments
Open
3 tasks

javascript cookies missing "SameSite" attribute #1413

GuySartorelli opened this issue Dec 11, 2022 · 0 comments
Labels
affects/v4 affects/v5 impact/medium type/bug

Comments

@GuySartorelli
Copy link
Member

GuySartorelli commented Dec 11, 2022 •
edited by maxime-rainville
Loading

We use the jquery-cookie library to handle cookies from a javascript context. Unfortunately any cookies it adds seem to be missing the "SameSite" attribute. For now that only causes a warning in the console, but eventually these cookies will be outright rejected.

Acceptance Criteria

  • All cookies added via javascript include an appropriate value for the "SameSite" attribute
    or
  • We stop defining cookies in the front end altogether and remove jquery-cookie.

Stretch goal

  • The value for the "SameSite" attribute for cookies added via javascript can be defined by a developer
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
affects/v4 affects/v5 impact/medium type/bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@GuySartorelli