Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prefer-lowest build uses installer version that may not be the lowest that module supports #93

Closed
GuySartorelli opened this issue May 21, 2024 · 3 comments
Assignees
Labels

Comments

@GuySartorelli
Copy link
Member

GuySartorelli commented May 21, 2024

Prefer-lowest builds install the version of installer that all the other CI runs use, which may not respect the actual dependencies for the module.
This can result in problems we aren't catching when we forget to bump dependencies.

Acceptance criteria

  • When CI runs include an installer version being added by the matrix, the version of installer used in the prefer-lowest build is the lowest version allowed in the dependencies for that module

PRs

@emteknetnz
Copy link
Member

Example run https://github.com/emteknetnz/silverstripe-elemental/actions/runs/9752302859

Composer bit looks like this running on the 5 branch for the --prefer-lowest build:

image

All other jobs just use installer 5.x-dev

@GuySartorelli
Copy link
Member Author

PR merged and new version tagged.
Reassigning to Steve to double check it works as expected

@emteknetnz
Copy link
Member

It's doing what it should

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants