Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"make_latest" setting is incorrect for tagging patch releases #74

Closed
GuySartorelli opened this issue Jul 10, 2023 · 2 comments
Closed

Comments

@GuySartorelli
Copy link
Member

GuySartorelli commented Jul 10, 2023

The current "make_latest" setting is incorrectly marking patch releases in the 4.x release line as the "latest" release, despite having higher semver releases (i.e. stuff in the 5.x release line) available.

e.g. see https://github.com/silverstripe/silverstripe-framework/releases - the release for 4.13.11 was marked as latest despite a higher semver release being available.
4.13.11 is marked as latest when it isn't the latest release

PRs

@GuySartorelli GuySartorelli transferred this issue from silverstripe/gha-tag-release Jul 10, 2023
@emteknetnz emteknetnz self-assigned this Jul 10, 2023
@emteknetnz
Copy link
Member

Need to change https://github.com/silverstripe/gha-tag-release/blob/1.1/action.yml#L172 from "legacy" to "true"|"false"

Best guess is that "legacy" treats new releases on older majors as the "latest" which is not our interpretation

We'll need to work this out manually - make an additional API in gha-tag-release that call the tags endpoint and does something similar to https://github.com/silverstripe/gha-ci/blob/1.4/.github/workflows/ci.yml#L815 to work out what the highest stable tag is, and the new tag would be newer than that, either a higher minor version or just a higher patch version

@GuySartorelli
Copy link
Member Author

PR merged and action tagged.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants