Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ENH Allow workflow_dispatch event #9

Merged

Conversation

emteknetnz
Copy link
Member

Copy link
Member

@GuySartorelli GuySartorelli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The commit message is "Allow workflow_dispatch event" but this PR is clearly doing a lot more than that.
I haven't reviewed the rest of the changes yet because it's not clear to me why they're there. What problem are the other changes solving?

Please answer that question for me, and update the commit message to something that covers all the changes in this commit.

@emteknetnz
Copy link
Member Author

The commit message is actually fairly accurate. Previously this action was only running on tag so env variable GITHUB_REF: ${{ github.ref }} was always set to semver tag. When running workflow_dispatch however there is github.ref is not a tag so instead I've updated the action in that scenario to auto-tag based on the 'highest' semver tag according to the github api tags endpoint

action.yml Outdated Show resolved Hide resolved
action.yml Show resolved Hide resolved
@emteknetnz emteknetnz force-pushed the pulls/1.0/auto-tag-dispatch branch from 1f6b13c to f86e00b Compare August 20, 2023 23:38
@emteknetnz
Copy link
Member Author

@GuySartorelli Have updated code and manually verified on https://github.com/emteknetnz/gha-issue/tags that the updated logic works for both manually created tags (1.0.7, though the v1 tag has since been updated) and automatic tags (called via github-action api by action-ci.yml after it automatically tags a release - 1.0.8 - v1 tag matches)

@GuySartorelli GuySartorelli merged commit 2c9d8d5 into silverstripe:1.0 Aug 21, 2023
@GuySartorelli GuySartorelli deleted the pulls/1.0/auto-tag-dispatch branch August 21, 2023 00:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants