From d5dad550f7780c155db80bb2b8b0e70ff61a8bf0 Mon Sep 17 00:00:00 2001 From: Steve Boyd Date: Mon, 1 Nov 2021 17:18:06 +1300 Subject: [PATCH 1/5] MNT Ignore some additional failures --- .eslintrc.js | 9 +++++++++ 1 file changed, 9 insertions(+) diff --git a/.eslintrc.js b/.eslintrc.js index d0133af..ff000c4 100644 --- a/.eslintrc.js +++ b/.eslintrc.js @@ -41,6 +41,15 @@ module.exports = { 'rules': Object.assign({}, todo, { + // turned off otherwise non-admin modules will complain about importing components from admin + // via the novel silverstripe js component sharing setup + 'import/no-extraneous-dependencies': [ + 'off' + ], + // turned off to allow the using of the js file extension for /boot/index.js + 'import/extensions': [ + 'off' + ], // turned off because the PHP side returns dangling properties which trigger this... // could revise later and add exceptions for PHP data 'no-underscore-dangle': [ From 49e3ec031cc5f90bde523e5c6f30a1dfcaefb988 Mon Sep 17 00:00:00 2001 From: Steve Boyd Date: Mon, 8 Nov 2021 16:17:13 +1300 Subject: [PATCH 2/5] MNT Disallow js file extensions on import --- .eslintrc.js | 4 ---- 1 file changed, 4 deletions(-) diff --git a/.eslintrc.js b/.eslintrc.js index ff000c4..6405261 100644 --- a/.eslintrc.js +++ b/.eslintrc.js @@ -46,10 +46,6 @@ module.exports = { 'import/no-extraneous-dependencies': [ 'off' ], - // turned off to allow the using of the js file extension for /boot/index.js - 'import/extensions': [ - 'off' - ], // turned off because the PHP side returns dangling properties which trigger this... // could revise later and add exceptions for PHP data 'no-underscore-dangle': [ From 5c771c27baa6d0bbe7c1866b0915f32f6d7588c2 Mon Sep 17 00:00:00 2001 From: Steve Boyd Date: Mon, 8 Nov 2021 17:45:05 +1300 Subject: [PATCH 3/5] MNT Reimplement allowing js file extension --- .eslintrc.js | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/.eslintrc.js b/.eslintrc.js index 6405261..0f67927 100644 --- a/.eslintrc.js +++ b/.eslintrc.js @@ -46,6 +46,11 @@ module.exports = { 'import/no-extraneous-dependencies': [ 'off' ], + // turned off to allow js file extension in require statements + // admin bundle.js, vendor.js and others seem to require the file extensions + 'import/extensions': [ + 'off' + ], // turned off because the PHP side returns dangling properties which trigger this... // could revise later and add exceptions for PHP data 'no-underscore-dangle': [ From b07536bd05347cd255ec46825299d17478804629 Mon Sep 17 00:00:00 2001 From: Steve Boyd Date: Thu, 11 Nov 2021 11:08:12 +1300 Subject: [PATCH 4/5] MNT Dissallow extentions in require statements --- .eslintrc.js | 5 ----- 1 file changed, 5 deletions(-) diff --git a/.eslintrc.js b/.eslintrc.js index 0f67927..6405261 100644 --- a/.eslintrc.js +++ b/.eslintrc.js @@ -46,11 +46,6 @@ module.exports = { 'import/no-extraneous-dependencies': [ 'off' ], - // turned off to allow js file extension in require statements - // admin bundle.js, vendor.js and others seem to require the file extensions - 'import/extensions': [ - 'off' - ], // turned off because the PHP side returns dangling properties which trigger this... // could revise later and add exceptions for PHP data 'no-underscore-dangle': [ From 40263b2f8f9c454f0c4d582d33ec1b08495c82e2 Mon Sep 17 00:00:00 2001 From: Steve Boyd Date: Thu, 11 Nov 2021 14:34:32 +1300 Subject: [PATCH 5/5] DEP Update version --- package.json | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/package.json b/package.json index 84ca084..640ebf5 100644 --- a/package.json +++ b/package.json @@ -1,6 +1,6 @@ { "name": "@silverstripe/eslint-config", - "version": "0.0.5", + "version": "0.0.6", "description": "SilverStripe config files for eslint", "engines": { "node": ">= 6.x"